Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(warpChecker): Support Renzo PZETH route #4628

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Mo-Hussain
Copy link
Contributor

@Mo-Hussain Mo-Hussain commented Oct 4, 2024

Description

  • support Renzo PZETH warp route in checker

Drive-by changes

  • introduce CheckerWarpRouteIds enum for warp routes that are supported in the checker, eclipse and sol routes are not currently supported

Testing

Manual

Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: 389fd91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

InevmInjectiveINJ = 'INJ/inevm-injective',
MantapacificNeutronTIA = 'TIA/mantapacific-neutron',
}

// add new warp route ids here if they are supported by the checker tooling, add an entry to warpConfigGetterMap also
export enum CheckerWarpRouteIds {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I split this out into a separate enum as not all warp routes are support by the checker yet

@Mo-Hussain Mo-Hussain self-assigned this Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (3662297) to head (389fd91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4628   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files         100      100           
  Lines        1423     1423           
  Branches      181      181           
=======================================
  Hits         1051     1051           
  Misses        351      351           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 75.71% <ø> (ø)
isms 78.94% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

@Mo-Hussain Mo-Hussain marked this pull request as ready for review October 5, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant