Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): check for sufficient msgValue for AggregationHook #4673

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Oct 12, 2024

Description

  • fixes misuse of aggregation hook funds for relaying messages by making sure msg.value is adequate and refunding if excess.

Drive-by changes

  • None

Related issues

Backward compatibility

No, needs new deployments of aggregationHooks

Testing

Unit

Copy link

changeset-bot bot commented Oct 12, 2024

⚠️ No Changeset found

Latest commit: f8d83ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.94%. Comparing base (46044a2) to head (f8d83ed).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4673      +/-   ##
==========================================
+ Coverage   73.85%   73.94%   +0.09%     
==========================================
  Files         100      100              
  Lines        1423     1428       +5     
  Branches      181      182       +1     
==========================================
+ Hits         1051     1056       +5     
  Misses        351      351              
  Partials       21       21              
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 76.27% <100.00%> (+0.56%) ⬆️
isms 78.94% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant