Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement reorg audit remediations #4682

Merged
merged 4 commits into from
Oct 15, 2024
Merged

feat: implement reorg audit remediations #4682

merged 4 commits into from
Oct 15, 2024

Conversation

paulbalaji
Copy link
Contributor

@paulbalaji paulbalaji commented Oct 15, 2024

Description

Bump up .registryrc and update agent configs with updated chain metadata including:

  • reorg periods
  • technical stack

Updates originally made in hyperlane-xyz/hyperlane-registry#276

Relies on objMerge to be fixed #4678

Drive-by changes

  • remove extraneous overrides + bring exiting relayer env vars into config
    • so it's in the image build directly, and we minimise break-glass-in-case-of-emergency overrides to the stateful set
  • ensure txOverrides are only included if defined in infra or registry
    • ensure we delete txo verrides from the read-in config, before merging with the generated config

Related issues

na

Backward compatibility

yes

Testing

na

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 6f59ee9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from pb/fix-objmerge to main October 15, 2024 13:26
@paulbalaji paulbalaji marked this pull request as draft October 15, 2024 13:31
@paulbalaji paulbalaji marked this pull request as ready for review October 15, 2024 13:52
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (f1712de) to head (6f59ee9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4682   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files         100      100           
  Lines        1423     1423           
  Branches      181      181           
=======================================
  Hits         1051     1051           
  Misses        351      351           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 75.71% <ø> (ø)
isms 78.94% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

@paulbalaji paulbalaji added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit c08d842 Oct 15, 2024
41 checks passed
@paulbalaji paulbalaji deleted the pb/reorg-updates branch October 15, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants