Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Record transaction with non-native fees #4683

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Oct 15, 2024

Description

Record transaction with non-native fees. Fees will be recorded as a huge number: max value of unsigned 256-bit long integer.

Backward compatibility

Yes

Testing

Manual testing of Scraper

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: ce0db4a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.85%. Comparing base (f1712de) to head (ce0db4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4683   +/-   ##
=======================================
  Coverage   73.85%   73.85%           
=======================================
  Files         100      100           
  Lines        1423     1423           
  Branches      181      181           
=======================================
  Hits         1051     1051           
  Misses        351      351           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 75.71% <ø> (ø)
isms 78.94% <ø> (ø)
token 88.23% <ø> (ø)
middlewares 77.39% <ø> (ø)

@ameten ameten added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 110d9d8 Oct 15, 2024
36 checks passed
@ameten ameten deleted the ameten/dummy-gas-price-for-non-native-token branch October 15, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants