-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial step to implementing support for invoke command #403
Initial step to implementing support for invoke command #403
Conversation
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
echo "FABLO_HOME: $FABLO_HOME" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those two lines can be removed
--waitForEventTimeout 90s \ | ||
2>&1 | ||
|
||
echo "Executing chaincode invoke command..." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant log message
local channel="$1" | ||
local chaincode="$2" | ||
local peers="$3" | ||
local command="$4" | ||
local transient="$5" | ||
|
||
echo "-> Chaincode invoke:" | ||
echo "Channel: $channel" | ||
echo "Chaincode: $chaincode" | ||
echo "Peers: $peers" | ||
echo "Command: $command" | ||
echo "Transient: $transient" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a consistent convention, like the one we use for instance here:
chaincodePackage() {
local CLI_NAME=$1
local PEER_ADDRESS=$2
local CHAINCODE_NAME=$3
local CHAINCODE_VERSION=$4
local CHAINCODE_LABEL="${CHAINCODE_NAME}_$CHAINCODE_VERSION"
local CHAINCODE_LANG=$5
echo "Packaging chaincode $CHAINCODE_NAME..."
inputLog "CHAINCODE_VERSION: $CHAINCODE_VERSION"
inputLog "CHAINCODE_LANG: $CHAINCODE_LANG"
inputLog "PEER_ADDRESS: $PEER_ADDRESS"
inputLog "CLI_NAME: $CLI_NAME"
So:
- snake case with capital letters for variable names
- and
inputLog
instead of echo
Signed-off-by: Joan Ndegwa <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: Joan Ndegwa <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: Joan Ndegwa <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
Signed-off-by: jnjerin <[email protected]>
This PR fixes a few issues caused by npm and implements support for invoke command for the simplest use case in issue #390:
Fixes errors caused by npm when running tests:
samples/chaincodes/chaincode-kv-node/.nvmrc
Possible fix for:
Chaincode Sample nvm version problem. #348
Issue with NodeJS versioning #328
Created a new script
chaincode-scripts.sh
to handledocker exec
Created the invoke command for its simplest use case
Update
CHANGELOG.md
with the new changes