Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for detecting struct only being used as array of struct #2061

Merged

Conversation

tonykwok1992
Copy link
Contributor

@tonykwok1992 tonykwok1992 commented Jun 6, 2024

What does this PR do?

Bug fix for detecting struct only being used as array of struct during wrapper generation, example of such contract is in test case

Where should the reviewer start?

All files

Why is it needed?

Bug fix

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

Signed-off-by: tonykwok1992 <[email protected]>
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo
Copy link
Contributor

@tonykwok1992 plz fix the conflicts

@tonykwok1992
Copy link
Contributor Author

@tonykwok1992 plz fix the conflicts

done

@NickSneo NickSneo merged commit 11bb23c into hyperledger-web3j:main Jun 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants