fix links to other docs #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrii Spivak <[email protected]>
|
@andrii482 -- hello. I'm a fellow contributor like yourself. I was looking at the results of this PR at https://hyperledger-fabric-ca--409.org.readthedocs.build/en/409/deployguide/cadeploy.html ... it looks like your change makes these links go from working to NOT working. To me. But maybe I'm misunderstanding... check out https://hyperledger-fabric-ca.readthedocs.io/en/latest/deployguide/cadeploy.html to see what I mean. Is this a mistake? Can we close this PR? |
|
Fabric uses a mix of md files and rst files, we've found it best to link to the html files that get generated in the doc build. I'll go ahead and close. Thank you for the effort though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Some links need to be fixed