Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version in README #430

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Update Go version in README #430

merged 1 commit into from
Aug 9, 2024

Conversation

denyeart
Copy link
Contributor

@denyeart denyeart commented Aug 8, 2024 •
edited
Loading

Update Go version in README.

@denyeart denyeart requested a review from a team as a code owner August 8, 2024 16:17
bestbeforetoday
bestbeforetoday approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to rename the commit as "Rename Go version in README" (rather than Docker version) on merge since that's what changed. Otherwise looks good

@denyeart
Update Go version in README
e78908e 
Update Go version in README.

Signed-off-by: David Enyeart <[email protected]>
@denyeart denyeart changed the title Update Docker version in README Update Go version in README Aug 9, 2024
@denyeart
Copy link
Contributor Author

denyeart commented Aug 9, 2024

You might want to rename the commit as "Rename Go version in README" (rather than Docker version) on merge since that's what changed. Otherwise looks good

Thanks... I was going to update both... fixed to indicate just Go now!

@bestbeforetoday bestbeforetoday merged commit 9f4df4b into hyperledger:main Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestbeforetoday bestbeforetoday bestbeforetoday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denyeart @bestbeforetoday