Fix build break #305
Merged
Fix build break #305
+1,638
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
build-fix
branch
2 times, most recently
from
af94f18
to
d16079c
Compare
New version of grpc-js required 'fs/promises', which does not exist in the particular version of Node 12 included in the hyperledger/fabric-nodeenv:2.2 image. This was fixed in grpc-js v1.12.2. This change includes npm-shrinkwrap.json files for the Node chaincode used by tests to avoid any unexpected future dependency version resolution changes. Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
build-fix
branch
from
d16079c
to
d0f4c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of grpc-js required 'fs/promises', which does not exist in the particular version of Node 12 included in the
hyperledger/fabric-nodeenv:2.2 image. This was fixed in grpc-js v1.12.2.
This change includes npm-shrinkwrap.json files for the Node chaincode used by tests to avoid any unexpected future dependency version resolution changes.