Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: increase type safety of block lifecycle #5140

Merged
merged 1 commit into from
Oct 11, 2024
Merged

refactor: increase type safety of block lifecycle #5140

merged 1 commit into from
Oct 11, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Oct 9, 2024

Context

  • increased type safety around block creation
  • introduced new Created event for blocks
  • relaxed conditions for signature validation

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

  • If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@github-actions github-actions bot added the api-changes Changes in the API for client libraries label Oct 9, 2024
@mversic mversic mentioned this pull request Oct 10, 2024
Draft
s8sato
s8sato reviewed Oct 10, 2024
View reviewed changes
crates/iroha_data_model/src/block.rs Show resolved Hide resolved
crates/iroha_core/src/block.rs Show resolved Hide resolved
crates/iroha_data_model/src/block.rs Outdated Show resolved Hide resolved
crates/iroha_core/src/sumeragi/main_loop.rs Show resolved Hide resolved
@mversic mversic force-pushed the new_block_lifecycle branch 2 times, most recently from f526f39 to f11c187 Compare October 10, 2024 06:55
@mversic mversic mentioned this pull request Oct 10, 2024
Open
@mversic mversic enabled auto-merge (squash) October 10, 2024 13:14
@mversic mversic merged commit c1b8563 into hyperledger:main Oct 11, 2024
18 of 19 checks passed
@mversic mversic deleted the new_block_lifecycle branch October 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dima74 dima74 dima74 approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@mversic mversic

@s8sato s8sato

Labels
api-changes Changes in the API for client libraries
Projects
Iroha
Status: Testing & Verification
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mversic @dima74 @s8sato