Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests runner #17

Closed
wants to merge 19 commits into from
Closed

Tests runner #17

wants to merge 19 commits into from

Conversation

GirZ0n
Copy link
Collaborator

@GirZ0n GirZ0n commented Jul 24, 2023

No description provided.

nbirillo
nbirillo requested changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks awesome, I have only small comments. Also, you need to add tests - for the functionality, another one that just runs the scripts

jba/src/jba/tests/tests_parser.py Outdated Show resolved Hide resolved
jba/src/jba/tests/tests_parser.py Outdated Show resolved Hide resolved
@GirZ0n GirZ0n closed this Aug 6, 2023
@GirZ0n GirZ0n deleted the tests-runner branch August 6, 2023 10:27
@GirZ0n
Copy link
Collaborator Author

GirZ0n commented Aug 6, 2023

Closed due to splitting into #18 and #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbirillo nbirillo nbirillo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GirZ0n @nbirillo