Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspections analysis #26

Merged
merged 42 commits into from
Oct 24, 2023
Merged

Inspections analysis #26

merged 42 commits into from
Oct 24, 2023

Conversation

GirZ0n
Copy link
Collaborator

@GirZ0n GirZ0n commented Oct 16, 2023 •
edited
Loading

Changes:

  • Added inspections analysis
  • Added the ij_config and new_format fields to HyperstyleEvaluationConfig
  • Improved the presentation of the executable command
  • Added task sorting to the visualization
  • Added plot descriptions to Aggregated timeline stats
  • Updated the whitelist
  • Bumped the version to 0.3.0
  • Updated the main JBA README file

GirZ0n and others added 26 commits October 16, 2023 14:47
@GirZ0n
fix: use the list2cmdline function for command representation
e5ef9a2
@GirZ0n
feat: add the ij_config and new_format fields
c3010d9 
fix: update typings
@GirZ0n
deps: add streamlit-diff-viewer
6110a30
@GirZ0n
feat: add the INSPECTIONS field
30aa8f6
@GirZ0n
feat: add the script for gathering inspections
3b23fc9
@GirZ0n
fix: add 'ij' and 'dataframe' to whitelist
54002e6
@GirZ0n
style: fix flake8's issues
820e3db
@GirZ0n
Sort whitelist (GitHub Actions)
df17cfa
@GirZ0n
fix: add WPS359 to whitelist
0639da2
@GirZ0n
Merge remote-tracking branch 'origin/inspections-analysis' into inspe…
c075fa1 
…ctions-analysis

# Conflicts:
#	spellcheck_whitelist.txt
@GirZ0n
Sort whitelist (GitHub Actions)
eafcb8e
@GirZ0n
feat: add inspections analysis
5c9b9a6
@GirZ0n
fix: add WPS359 to ignore
80e9812
@GirZ0n
fix: add new words to whitelist
526cdc5
@GirZ0n
deps: add plotly
f3fd0f0
@GirZ0n
fix: update the inspections column format
1f4dfc0
@GirZ0n
todo: added new todo
36f288b
@GirZ0n
Merge remote-tracking branch 'origin/inspections-analysis' into inspe…
9ec0934 
…ctions-analysis

# Conflicts:
#	spellcheck_whitelist.txt
@GirZ0n
Sort whitelist (GitHub Actions)
47d55b8
@GirZ0n
fix: fix small bug
fb974b0
@GirZ0n
Merge remote-tracking branch 'origin/inspections-analysis' into inspe…
14891f2 
…ctions-analysis
@GirZ0n
fix: make visualization look better
e78c7da
@GirZ0n
style: fix flake8's issues
2bc5f8b
@GirZ0n
style: fix flake8's issues
7f58998
@GirZ0n
style: make the code look better
6662713
@GirZ0n
fix: fix a small bug
c1ea2ae
@GirZ0n GirZ0n marked this pull request as ready for review October 18, 2023 11:57
@GirZ0n GirZ0n requested a review from nbirillo October 18, 2023 11:57
nbirillo
nbirillo requested changes Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice

jba/src/visualization/pages/4_Inspections_stats.py Outdated Show resolved Hide resolved
@GirZ0n GirZ0n requested a review from nbirillo October 23, 2023 12:04
nbirillo
nbirillo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice, I am not sure if we need to make strong reviews for the web part, since it is a prototype

@nbirillo nbirillo merged commit 4de5b5f into main Oct 24, 2023
2 checks passed
@nbirillo nbirillo deleted the inspections-analysis branch October 24, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbirillo nbirillo nbirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GirZ0n @nbirillo