Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure script refactoring #27

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Structure script refactoring #27

merged 8 commits into from
Oct 24, 2023

Conversation

GirZ0n
Copy link
Collaborator

@GirZ0n GirZ0n commented Oct 24, 2023 •
edited
Loading

Changes:

  • Refactored the prepare_course_data script. Now it can work with any course structure
  • Added new tests for the prepare_course_data script
  • Slightly changed the JBA tests folder structure
  • Updated the whitelist

@GirZ0n GirZ0n marked this pull request as ready for review October 24, 2023 12:18
@GirZ0n GirZ0n requested a review from nbirillo October 24, 2023 12:20
nbirillo
nbirillo approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thank you for the tests btw

@nbirillo nbirillo merged commit a01289f into inspections-analysis Oct 24, 2023
2 checks passed
@nbirillo nbirillo deleted the structure-script-refactoring branch October 24, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbirillo nbirillo nbirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GirZ0n @nbirillo