Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization prototype generalization #28

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Visualization prototype generalization #28

merged 9 commits into from
Nov 15, 2023

Conversation

GirZ0n
Copy link
Collaborator

@GirZ0n GirZ0n commented Oct 26, 2023 •
edited
Loading

Changes:

  • Added the --force-ignore-tests argument to the test_runner script
  • Added the ability to choose a file in the visualization
  • Added module name sanitization to the test_runner script
  • Added support for courses without sections
  • Added a basic stats in the General stats page

@GirZ0n GirZ0n requested a review from nbirillo November 13, 2023 09:08
@GirZ0n GirZ0n marked this pull request as ready for review November 13, 2023 09:08
@GirZ0n GirZ0n changed the title Visualization fix Visualization prototype generalization Nov 13, 2023
nbirillo
nbirillo requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@nbirillo nbirillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments

jba/src/inspections/analysis.py Outdated Show resolved Hide resolved
jba/src/inspections/analysis.py Outdated Show resolved Hide resolved
jba/src/inspections/analysis.py Outdated Show resolved Hide resolved
jba/src/inspections/analysis.py Outdated Show resolved Hide resolved
jba/src/inspections/analysis.py Outdated Show resolved Hide resolved
jba/src/visualization/common.py Show resolved Hide resolved
@GirZ0n GirZ0n requested a review from nbirillo November 15, 2023 13:36
@nbirillo nbirillo merged commit 914c356 into main Nov 15, 2023
2 checks passed
@nbirillo nbirillo deleted the visualization-fix branch November 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbirillo nbirillo nbirillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GirZ0n @nbirillo