-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lag metric for grouper #283
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #283 +/- ##
============================================
- Coverage 79.07% 79.06% -0.02%
Complexity 1231 1231
============================================
Files 110 110
Lines 4861 4863 +2
Branches 440 441 +1
============================================
+ Hits 3844 3845 +1
Misses 813 813
- Partials 204 205 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@rish691 @kotharironak I am not exactly sure what does |
…pertrace-ingester into fix_lag_metric_for_grouper
looks like it is time when span was received at normalizer. https://github.com/hypertrace/hypertrace-ingester/blob/main/span-normalizer/span-normalizer/src/main/java/org/hypertrace/core/spannormalizer/jaeger/JaegerSpanNormalizer.java#L116 |
Description
I see 2 potential issues with current arrival lag reporting:
original objective on 'arrival.lag' was to report lag at start of job. overtime this has been changed it seems, and currently it reports lag when trace is about to be emitted.
hence we are currently reporting
lag
including the time span spent in rawspangrouper.another issue is that, we are determining the lag based on
trace start time
which is set of grouper as currenttime. which does not give the correct value of lag. as lag represents how much delay as span has faced till now in the data pipeline.this PR it trying to address only the 2nd point. as of now.
For now i am of the opinion we can consider the metrics been reported as just lag instead of arrival lag. Grouper is already reporting at end of job. I have made changes to move enricher reporting also to end of enrichment.
any thoughts @ravisingal @surajpuvvada ?