-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the Select
component listboxOverflow
#1754
Conversation
f9cbf21
to
b9758df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1754 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 67 67
Lines 1205 1205
Branches 454 454
=========================================
Hits 1205 1205 ☔ View full report in Codecov by Sentry. |
b9758df
to
7291d7f
Compare
<Library.Example title="listboxOverflow"> | ||
<Library.Info> | ||
<Library.InfoItem label="description"> | ||
Determines the behavior of the listbox options when their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Determines the behavior of the listbox options when their | |
Determines the behavior of the listbox options when their |
"options" or "items"? The component is called Select.Option
but code examples tend to use the term "items" for the data arrays from which the options are generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would use "items" when conceptually talking about the entries of the list, and "options" when talking about the markup elements explicitly.
In this case, since we are talking about how they render, I think I would use "options".
But this is not a strong opinion, and I see a lot of grey areas in that reasoning, so I'm ok using a different wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would use "items" when conceptually talking about the entries of the list, and "options" when talking about the markup elements explicitly.
That makes sense.
7291d7f
to
3ebacea
Compare
The
listboxOverflow
prop was added in #1746. This PR documents it and adds examples.listbox-overflow-docs-2024-10-28_14.45.50.mp4