Add request to email.send_confirmation() in ResendEmailVerificationView #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Currently the email activation which is send when you request to resend the email verification link, the new link uses the domain specified in Djangos Sites package in the database. This links domain therefore might not be the same as the original email verification link.
For example:
Original email verification link:
http://localhost:8000/verify-email/<key>/
Resend email verification link:
http://example.com/verify-email/<key>/
This could be easily
Proposed Fix
Add
request
as parameter toemail.send_confirmation()
inResendEmailVerificationView
to allow url of the current website to be the target url for the email verification link (see below).Debugging Trace