Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with saving firmware files to local machine #2194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bfmvsa
Copy link
Contributor

@bfmvsa bfmvsa commented Sep 19, 2024

Looks like we had an issue saving downloaded firmware files to a local machine (Because of outdated chrome api). Fixed and tested on MacOS, if it is possible, please check on the other platforms before merging.
Also fixed filename of the files from always "inav.hex" to specific for downloaded firmware.

screenshot 2024-09-19 at 09 20 05

@bfmvsa
Copy link
Contributor Author

bfmvsa commented Sep 23, 2024

Maybe my description of the bug was unclear, so I'd like to explain it again.

When you load firmware by using "Load Firmware [Online]" you can download the .hex file to your local machine by clicking on the link in the progress bar (highlighted in the screenshot), it is not working because of outdated Chrome API, in this PR I've fixed it by using fs library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant