Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile change not working #2197

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

MrD-RC
Copy link
Collaborator

@MrD-RC MrD-RC commented Sep 21, 2024

Initially, I thought that the profiles were not changing when you selected a new profile from the select box. It turns out that this was only happening after setting up from the defaults dialog. The problem was that the periodicStatusUpdater was being stopped to perform the parameter upload. But not re-started. I added a function to resume the updater, and everything works as it should. I made a few other changes:

  • Tidied up the setting of the parameters for each profile
  • Added specific set profile messages, rather than loaded being repeated
  • Only show messages for the profiles that have changed, not all of them

Initially, I thought that the profiles were not changing when you selected a new profile from the select box. It turns out that this was only happening after setting up from the defaults dialog. The problem was that the `periodicStatusUpdater` was being stopped to perform the parameter upload. But not re-started. I added a function to resume the updater, and everything works as it should. I made a few other changes:
- Tidied up the setting of the parameters for each profile
- Added specific `set` profile messages, rather than `loaded` being repeated
- Only show messages for the profiles that have changed, not all of them
@MrD-RC MrD-RC added this to the 8.0 milestone Sep 21, 2024
@MrD-RC MrD-RC merged commit 1145424 into master Sep 21, 2024
5 checks passed
@MrD-RC MrD-RC deleted the MrD_Fix-profile-change-not-working branch September 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant