Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Corrected Handling of Observed Elements on GitHub Pages #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jaovitosr
Copy link

Pull Request Description

Problem

During tests with the Tobii Pro Fusion Eye Tracker, a limitation was identified where the extension failed to properly return user-observed elements, specifically on GitHub pages. The issue manifested as "undefined" values in the fields of the .xml files generated at the end of the execution.

Solution

To address this limitation, the capturing mechanisms for user-observed elements have been revised. The modification takes into account the unique structure of GitHub pages and ensures accurate retrieval of these elements. The result is reflected in the appropriate sections of the .xml files generated after the completion of tests.

Changes Made

  • Updated the element capturing logic to handle GitHub page structure.
  • Ensured proper representation of observed elements in the generated .xml files.
  • Conducted thorough testing to validate the changes.

@KangilPark KangilPark self-requested a review January 22, 2024 20:52
Copy link
Contributor

@KangilPark KangilPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto from #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants