-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Url encoding in images, dont render undefined images #713
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @iamvishnusankar on Vercel. @iamvishnusankar first needs to authorize it. |
Fixes #714 |
Can this be merged please? Image sitemaps do not work |
@iamvishnusankar can you merge this |
@jonluca Thanks a lot for this PR. I'm extremely sorry for taking this long to review this. Got busy with few personal projects. Looks like the build is failing due to incompatibility of node version. Can you please update the action file to set the node versions to next-sitemap/.github/workflows/test.yml Line 17 in 25bad1d
Once you push the changes, I'll merge the PR. |
Done |
…e cache in github actions
Pushed another update updating yarn. We probably shouldn't use |
@jonluca Yeah, Looks like the command is setting v4 now and it seems not resolving workspace modules. I tried upgrading the project to |
We could probably move to I just pushed an update to use bun to install the packages, but keep jest around for the tests. I think it all passes? |
@jonluca Thanks a lot for this PR! I have merged it! 🙏 Looks like there are some issues with the release pipeline. I'll be fixing it this weekend along with much needed fix for app dir routes groups. |
Hi @iamvishnusankar, do you already have a rough estimate on when this will be released? |
[Fix] Url encoding in images, dont render undefined images
The library was outputting invalid xml for URLs with query params.
This PR: