move empty check to validateIpAddress method

ibericode · Jan 8, 2019 · 1d24382 · 1d24382
1 parent 4b79a79
commit 1d24382
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Countries.php b/src/Countries.php
@@ -368,6 +368,10 @@ public function validateCountryCode(string $countryCode) : bool
      */
     public function validateIpAddress(string $ipAddress) : bool
     {
+        if (empty($ipAddress)) {
+            return false;
+        }
+
         return (bool) filter_var($ipAddress, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE);
     }
 
@@ -382,7 +386,7 @@ public function validateIpAddress(string $ipAddress) : bool
      */
     public function ip(string $ipAddress) : string 
     {
-        if (empty($ipAddress) || !$this->validateIpAddress($ipAddress)) {
+        if (!$this->validateIpAddress($ipAddress)) {
             return '';
         }