throw exception when rates file contains content that could not be un…

…serialized
ibericode · Sep 6, 2023 · 866b651 · 866b651
1 parent e218a03
commit 866b651
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -51,6 +51,7 @@ jobs:
 
       - name: "Install dependencies with Composer"
         uses: "ramsey/composer-install@v2"  
+
       - name: "Run PHPUnit"
         run: "vendor/bin/phpunit"
 
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -5,9 +5,9 @@
          beStrictAboutOutputDuringTests="true"
          bootstrap="vendor/autoload.php"
          colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
+         convertErrorsToExceptions="false"
+         convertNoticesToExceptions="false"
+         convertWarningsToExceptions="false"
          failOnRisky="true"
          failOnWarning="true"
          processIsolation="false"

diff --git a/src/Rates.php b/src/Rates.php
@@ -75,9 +75,11 @@ private function loadFromFile()
             ]
         ]);
 
-        if (is_array($data)) {
-            $this->rates = $data;
+        if (false === is_array($data)) {
+            throw new Exception("Unserializable file content");
         }
+
+        $this->rates = $data;
     }
 
     private function loadFromRemote()

diff --git a/tests/RatesTest.php b/tests/RatesTest.php
@@ -86,7 +86,7 @@ public function testRatesAreLoadedFromFile()
         // test by invalidating file and testing for exception
         file_put_contents('vendor/rates', 'foobar');
         $rates = new Rates('vendor/rates', 30, $client);
-        $this->expectError(Error::class);
+        $this->expectException(Exception::class);
         $this->assertEquals(21.0, $rates->getRateForCountry('NL'));
     }