fix variable name in Countries::ip method

ibericode · Jan 8, 2019 · e5092c5 · e5092c5
1 parent 95e0425
commit e5092c5
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/Countries.php b/src/Countries.php
@@ -355,7 +355,11 @@ public function inEurope(string $code) : bool
      */
     public function ip(string $ipAddress) : string 
     {
-        $url = 'https://ip2c.org/' . $ip;
+        if (empty($ipAddress)) {
+            return '';
+        }
+
+        $url = sprintf('https://ip2c.org/%s', urlencode($ipAddress));
 
         $curl_handle = curl_init();
         curl_setopt($curl_handle, CURLOPT_URL, $url);

diff --git a/tests/CountriesTest.php b/tests/CountriesTest.php
@@ -33,5 +33,13 @@ public function testInEurope() {
             self::assertTrue( $countries->inEurope( $country ) );
         }
     }
+
+     /**
+     * @covers Countries::ip
+     */
+    public function testIp() {
+        $countries = new Countries();
+        self::assertEmpty($countries->ip(''));
+    }
 
 }