Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stop Time Interpolation #998

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Add Stop Time Interpolation #998

merged 6 commits into from
Nov 21, 2023

Conversation

philip-cline
Copy link
Contributor

@philip-cline philip-cline commented Nov 5, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Front end PR to add support for stop time interpolation in the NormalizeStopTimes modal.
Backend PR: ibi-group/datatools-server#572
GTFS-lib PR: conveyal/gtfs-lib#399

@philip-cline philip-cline mentioned this pull request Nov 5, 2023
Merged
5 tasks
@AdrianaCeric AdrianaCeric self-assigned this Nov 6, 2023
@philip-cline
Copy link
Contributor Author

Note that in 62216ca I did some i18n but there remains a TODO to figure out how to apply strong formatting inside of i18n strings

AdrianaCeric
AdrianaCeric approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@AdrianaCeric AdrianaCeric removed their assignment Nov 8, 2023
miles-grant-ibigroup
miles-grant-ibigroup approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough although there are some strings you haven't localized. Is that intentional?

lib/editor/actions/tripPattern.js
return function (dispatch: dispatchFn, getState: getStateFn) {
const {data} = getState().editor
const {feedSourceId} = data.active
const sessionId = data.lock.sessionId || ''
const url = `/api/editor/secure/pattern/${patternId}/stop_times?feedId=${feedSourceId || ''}&sessionId=${sessionId}&stopSequence=${beginStopSequence}`
const url = `/api/editor/secure/pattern/${patternId}/stop_times?feedId=${feedSourceId || ''}&sessionId=${sessionId}&stopSequence=${beginStopSequence}&interpolateStopTimes=${interpolateStopTimes.toString()}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a crazy hack but glad it works

@philip-cline
Copy link
Contributor Author

philip-cline commented Nov 10, 2023 •
edited by miles-grant-ibigroup
Loading

Yeah that's intentional, there are <strong>, etc. tags in the text and we don't have an easy way of inserting those into i18n strings rn in Datatools

@philip-cline philip-cline merged commit 9087121 into dev Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianaCeric AdrianaCeric AdrianaCeric approved these changes

@miles-grant-ibigroup miles-grant-ibigroup miles-grant-ibigroup approved these changes

Assignees

@philip-cline philip-cline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philip-cline @AdrianaCeric @miles-grant-ibigroup