Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused error-prone submodule setup #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

proletarius101
Copy link

@proletarius101 proletarius101 commented Feb 16, 2023

According to https://git-scm.com/docs/gitsubmodules, there must be a working directory at path/to/bar/ if there's a submodule.foo.path = path/to/bar entry in .gitmodules. Failure to have this will result in errors in certain build environments (e.g. Flatpak: standardnotes/app#516)

Same as in rust-windowing#1575

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

According to https://git-scm.com/docs/gitsubmodules, there must be a working directory at path/to/bar/ if there's a submodule.foo.path = path/to/bar entry in .gitmodules. Failure to have this will result in errors in certain build environments (e.g. Flatpak: standardnotes/app#516)

Same as in rust-windowing#1575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant