feat(winit): client-side window drag resize support #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
changed the title
|
is there a reason this isnt merged yet? |
netraptor
reviewed
Nov 13, 2024
| ) -> Option< | ||
| impl FnMut(&winit::window::Window, &winit::event::WindowEvent<'_>) -> bool, | ||
| > { | ||
| if window.drag_resize_window(ResizeDirection::East).is_ok() { |
There was a problem hiding this comment.
I think its worth mentioning that this line appears to be the source of the libcosmic Windows resizing on start bug. I don't see another way of checking for this support in winit at runtime, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch was accepted into winit early this year. Iced has also already pulled a winit release that contains it. So it's just a matter of utilizing it here.
Requires iced-rs/winit#8Implements iced-rs/rfcs#14