Add access to bounds/content bounds from a scrollable viewport. #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er to perform certain scrollable optimizations as a consumer.
hecrj
requested changes
Sep 7, 2023
widget/src/scrollable.rs
Outdated
Comment on lines
1140
to
1148
| /// Returns the bounds of the current [`Viewport`]. | ||
| pub fn bounds(&self) -> Rectangle { | ||
| self.bounds | ||
| } | ||
|
|
||
| /// Returns the content bounds of the current [`Viewport`]. | ||
| pub fn content_bounds(&self) -> Rectangle { | ||
| self.content_bounds | ||
| } |
There was a problem hiding this comment.
Let's move these after relative_offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added access to the bounds and content bounds of a scrollable's viewport. This is necessary to perform some scrollable optimizations such as virtual lists without creating your own widget, and piggybacking on the scrollable.
Added 2 methods for accessing the corresponding bounds from
Viewport.