Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu to 22.0 #2510

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Update wgpu to 22.0 #2510

merged 3 commits into from
Sep 19, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jul 19, 2024

Closes #2417.
Closes #2507.

@hecrj hecrj added this to the 0.13 milestone Jul 19, 2024
@hecrj
Copy link
Member Author

hecrj commented Jul 21, 2024

This is waiting on a resolution of gfx-rs/wgpu#5756.

@hecrj hecrj mentioned this pull request Jul 21, 2024
@kmoon2437
Copy link
Contributor

I'm the person who opened #2507 and going to use this framework with vello crate. However, it requires version 0.3.69 of web-sys and makes conflict with iced. Can you solve it at first, please?

@hecrj hecrj modified the milestones: 0.13, 0.14 Sep 11, 2024
For now, this feature flag only enables validation
in `iced_wgpu`; which has become quite expensive
since its `0.20` release.
@hecrj
Copy link
Member Author

hecrj commented Sep 19, 2024

I have finally been able to trace down the root cause of the wgpu "issue" blocking this PR.

As I explain in my comment, it turns out it's not an issue at all and we can simply control the validation layers with a new feature flag: strict-assertions.

I see no reason for users of the library to run validation layers unless they are having issues, therefore the feature flag is disabled by default.

In my testing, disabling validation actually makes debug builds quite faster when using the Vulkan backend. So, the overhead has turned into an unexpected speedup!

I think we can finally merge this.

@hecrj hecrj merged commit b78b8bc into master Sep 19, 2024
30 checks passed
@hecrj hecrj deleted the wgpu-22.0 branch September 19, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants