Fix slider #2610
Closed
Fix slider #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, i'm starting to think its a cosmic only issue. Will see when they rebase their fork |
|
I think this reverts #1721. |
|
Initially, i wanted to fix a cosmic applet that use the slider from Iced but yeah, it will require more investigation from me. Sorry for the useless PR |
|
No worries! |
|
I tried to bring this up on discourse, but I guess not many people saw it. My suggestion is to have "saturation zones" at each end of the slider, where clicking that region would bring the slider to either 0% or 100%. The length of these regions would be equal to the half-width of the handle. So the slider would look the same as it does now, but the way it responds to events would be modified slightly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix pop-os/cosmic-settings#628
currently, the grab handle seems a little off, but i'm not sure this is a layout bug.
master
pr