Change lifetime of markdown IntoIterator Item, as it does not need to live as long as the returned Element #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed to live as long as the returned Element.
hecrj
approved these changes
Oct 2, 2024
hecrj
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original lifetime of Item indicated that the Items yielded by an iterator must live as long as the returned Element, which is not required.
This made it difficult to work with data wrapped in a
MutexorRwLockas an iterator, as the guard creates a temporary variable which the compiler thinks needs to be held for the lifetime of the Element.This adds another lifetime to indicate that
Item's yielded byIntoIteratoronly need to last as long as the view function itself.