A collection of "low-hanging fruit" refactors #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
changed the title
mfisher87
commented
Sep 18, 2024
| "ATL23", | ||
| ], error_msg | ||
| else: | ||
| if not isinstance(product, str): |
There was a problem hiding this comment.
I find the style of:
if not valid:
raise ...
# main logic heremore readable than:
if valid:
# main logic here
else:
raise ...
mfisher87
commented
Sep 18, 2024
| @@ -330,13 +332,13 @@ def gt2spot(gt, sc_orient): | |||
| elif gr_lr == "r": | |||
| spot = 6 | |||
|
|
|||
| if "spot" not in locals(): | |||
There was a problem hiding this comment.
Looking at locals() is a smell to me. I feel it may throw off some other code-readers.
mfisher87
commented
Sep 18, 2024
mfisher87
commented
Sep 18, 2024
| if not hasattr(self, "_granules") or self._granules is None: | ||
| self._granules = Granules() | ||
|
|
||
| return self._granules |
There was a problem hiding this comment.
Looks to me like self.granules is static and could be set at init-time as a class attribute, but then we wouldn't get this awesome docstring. I changed the method to a cached_property to, IMO, get the best qualities of both.
mfisher87
commented
Sep 18, 2024
| if self._ext_type == "bounding_box": | ||
| cmr_extent = ",".join(map(str, self._spatial_ext)) | ||
| if self.extent_type == "bounding_box": | ||
| return ",".join(map(str, self._spatial_ext)) |
There was a problem hiding this comment.
When there's an assignment like this, that tells me that something may be done to this variable after the conditional ends. Instead, return tells the reader right away that nothing further will happen.
mfisher87
force-pushed
the
low-hanging-refactors
branch
from
91bd9a8
to
b75d000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
To be merged only after merging #605 and rebasing
I'm happy to split this in to multiple PRs, but there's a lot of disparate changes here and I didn't want to flood the queue before showing you the whole pile. Let me know!