Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup Tile namespace #162

Merged
merged 3 commits into from
May 27, 2024
Merged

cleanup Tile namespace #162

merged 3 commits into from
May 27, 2024

Conversation

mgates3
Copy link
Collaborator

@mgates3 mgates3 commented Feb 10, 2024

  1. The tile namespace was previously added to Tile_blas.hh. This adds it to Tile_lapack.hh and similar headers.
  2. Many files needlessly included Tile_blas.hh and similar headers. If a file doesn't call a tile:: function, it shouldn't include the header.
  3. Largely unrelated, remove custom real, imag, instead using ones from std, and remove custom make, instead using blas::make_scalar. The issue showed up when functions moved into the tile namespace, so make was no longer in the same namespace.

Copy link
Collaborator Author

@mgates3 mgates3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed.

@mgates3 mgates3 merged commit d58dd94 into icl-utk-edu:master May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant