New matrix generators #199
Conversation
…iag, toeppen, pei, parter, moler,
There was a problem hiding this comment.
This is fine for now. I'm not sure if uplo, diag, and the intermediate test_matgen_dispatch routine are useful in this context, but we can address those later.
| @@ -322,6 +322,8 @@ std::vector< testsweeper::routines_t > routines = { | |||
| { "scale_row_col", test_scale_row_col, Section::aux }, | |||
| { "", nullptr, Section::newline }, | |||
|
|
|||
| { "matgen", test_matgen, Section::aux_gen }, | |||
There was a problem hiding this comment.
It probably makes more sense to move matgen to the end, after all the set routines.
Also, add a line:
{ "", nullptr, Section::newline },
Check what ./tester -h prints out.
Hmm... on a second look, adding a newline may not make any difference, since it has its own section. I'll think about it.
| //using real_t = blas::real_type<scalar_t>; | ||
| //using blas::real; | ||
| //using blas::imag; | ||
| //using slate::ceildiv; |
There was a problem hiding this comment.
I commented out some of these that are unused and the compiler might complain about. I also removed alpha and beta, which I don't think will be used for matgen.
GNUmakefile
Outdated
There was a problem hiding this comment.
I added matgen to the Makefile.
Currently, the Makefile explicitly lists all files, while CMake compiles all *.cc files. (BLAS++ and LAPACK++ are the opposite — Makefile compiles all *.cc files, while CMake explicitly lists them. Maybe someday we'll make that consistent.
| @@ -669,6 +669,8 @@ def filter_csv( values, csv ): | |||
|
|
|||
| [ 'scale_row_col', gen + dtype + mn + equed + nonuniform_nb + ge_matrix ], | |||
|
|
|||
| [ 'matgen', gen_no_nb + dtype + ' --dim 20 --nb 4 --verbose 4' + ge_matrix ], | |||
|
|
|||
There was a problem hiding this comment.
I updated this so it tested only 20x20 matrix, nb 4. We need to revise run_tests.py, or use a different script, to save output to out and compare to ref.
No description provided.