Add support for custom link regexes via TextEditorOptions. #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My use-case is that I would like hyperlinks to be able to have semicolons and commas in and still parse. During the implementation of this PR, I realised that there is another extensibility point, subclassing LinkElementGenerator and then adding it to the TextView.ElementGenerators collection, but I found this hard to discover without first digging into the code, and I think there's still potentially value in exposing this property more easily via TextEditorOptions. That being said, I can understand if you don't want to accept the PR as a result of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use-case is that I would like hyperlinks to be able to have semicolons and commas in and still parse.
During the implementation of this PR, I realised that there is another extensibility point, subclassing
LinkElementGeneratorand then adding it to theTextView.ElementGeneratorscollection, but I found this hard to discover without first digging into the code, and I think there's still potentially value in exposing this property more easily viaTextEditorOptions. That being said, I can understand if you don't want to accept the PR as a result of this.