-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify default field value for field with type that uses generic parameters with defaults #73
Open
treysidechain
wants to merge
11
commits into
idanarye:master
Choose a base branch
from
tlowerison:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3c4aed3
add support for initializing builder's generic parameters with defaul…
treysidechain 7d22d8b
add support for specifying default values on fields which have the fi…
treysidechain 8c0be3e
reduce semver strictness on new dependencies
treysidechain 891dcbf
add usage of proc-macro-crate to support package renames in applicati…
treysidechain 4094904
add example of working support for issue 44
treysidechain 9e5ee22
undo refactor of moving proc-macros into separate crate
treysidechain a708e3c
remove pretty print debug feature
treysidechain 6022ce3
ran cargo fmt
treysidechain baaf547
fix bug where field types which depend on both generic params with an…
treysidechain fb96cc6
add complex default/no-default generic dependent field type test to e…
treysidechain 7ac7198
restore necessity for the #[builder(default)] field attribute to be a…
treysidechain File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
use typed_builder::TypedBuilder; | ||
|
||
#[derive(TypedBuilder)] | ||
pub struct Props<'a, OnInput: FnOnce(usize) -> usize = Box<dyn FnOnce(usize) -> usize>> { | ||
#[builder(default, setter(into))] | ||
pub class: Option<&'a str>, | ||
pub label: &'a str, | ||
#[builder(setter(into))] | ||
pub on_input: Option<OnInput>, | ||
} | ||
|
||
#[derive(TypedBuilder)] | ||
struct Foo<T = usize> { | ||
#[builder(default = 12)] | ||
x: T, | ||
} | ||
|
||
#[allow(dead_code)] | ||
#[derive(TypedBuilder)] | ||
struct Bar<T, U = usize, V = usize> { | ||
t: T, | ||
#[builder(default = 12)] | ||
u: U, | ||
v: (T, U, V), | ||
} | ||
|
||
fn main() { | ||
let props = Props::builder().label("label").on_input(|x: usize| x).build(); | ||
assert_eq!(props.class, None); | ||
assert_eq!(props.label, "label"); | ||
assert_eq!((props.on_input.unwrap())(123), 123); | ||
|
||
assert_eq!(Foo::builder().build().x, 12); | ||
|
||
assert_eq!(Bar::builder().t("test").v(("t", 0, 3.14f64)).build().v.0, "t"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you doing this to determine if the type depends on the generic parameter? I'd prefer doing this with https://docs.rs/syn/latest/syn/visit/index.html