Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst and add docker exit code inside workflows [CI] #240

Merged
merged 9 commits into from
Oct 2, 2023

Conversation

saicharan0112
Copy link
Collaborator

remove info on the generators that is present already inside main documentation, tabular the generators data and point to the main documentation

remove info on the generators that is present already inside main documentation, tabular the generators data and point to the main documentation
@msaligane
Copy link
Member

@chetanyagoyal FYI.

@saicharan0112
Copy link
Collaborator Author

@msaligane please merge this first. It adds one more check to catch errors inside the docker container.

@saicharan0112 saicharan0112 changed the title Update README.rst Update README.rst and add docker exit code inside workflows [CI] Oct 1, 2023
@saicharan0112
Copy link
Collaborator Author

saicharan0112 commented Oct 1, 2023

FYI, ldo-gen is broken (regex issue #241 ). Temp-sense error is more of a python import that is coming from #226 .

@harshkhandeparkar
Copy link
Collaborator

FYI, ldo-gen is broken (regex issue #241 ) and there is something wrong with the cryo-gen as well. Temp-sense error is more of a python import that is coming from #226 .

ldo-gen should be fixed in #229 but the Python error seems to be happening due to Python version 3.7.x. When I made the PR, it was working for me locally but I use Python version 3.10+.

@saicharan0112
Copy link
Collaborator Author

FYI, ldo-gen is broken (regex issue #241 ) and there is something wrong with the cryo-gen as well. Temp-sense error is more of a python import that is coming from #226 .

ldo-gen should be fixed in #229 but the Python error seems to be happening due to Python version 3.7.x. When I made the PR, it was working for me locally but I use Python version 3.10+.

I can confirm that this works for 3.10.

@msaligane msaligane merged commit 995d65d into idea-fasoc:main Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants