Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem of make not exiting on subprocess errors #250

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Fix problem of make not exiting on subprocess errors #250

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c3f7f4
add exit statements for cryo_gen suprocess calls
chetanyagoyal Oct 10, 2023
43a969b
add proper subprocesses exit statements temp_sense_gen
chetanyagoyal Oct 10, 2023
888db06
update exit calls in subprocesses for ldo_gen
chetanyagoyal Oct 10, 2023
4147d43
Update save_images.tcl
chetanyagoyal Oct 27, 2023
5ed4ba6
Update save_images.tcl
chetanyagoyal Oct 27, 2023
b43eef0
Merge branch 'idea-fasoc:main' into main
chetanyagoyal Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 36 additions & 15 deletions openfasoc/generators/cryo-gen/tools/cryo-gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,13 @@
if not os.path.isdir(sky130A_path):
os.mkdir(sky130A_path)
try:
sp.Popen(
[
"sed -i 's/set PDKPATH \".*/set PDKPATH $env(PDK_ROOT)\/sky130A/' $PDK_ROOT/sky130A/libs.tech/magic/sky130A.magicrc"
],
shell=True,
).wait()
cmd = ["sed -i 's/set PDKPATH \".*/set PDKPATH $env(PDK_ROOT)\/sky130A/' $PDK_ROOT/sky130A/libs.tech/magic/sky130A.magicrc"]
p = sp.Popen(cmd, shell=True)
p.wait()
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) + \
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)
except:
pass
shutil.copy2(os.path.join(pdk, "libs.tech/magic/sky130A.magicrc"), sky130A_path)
Expand Down Expand Up @@ -155,42 +156,53 @@
print()
if args.mode == "verilog":
print("Exiting tool....")
exit()
sys.exit(0)

print("#----------------------------------------------------------------------")
print("# Run Synthesis and APR")
print("#----------------------------------------------------------------------")
# make with different deisgn config

cmd = ["make", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file]
p = sp.Popen(
["make", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file], cwd=flowDir
cmd, cwd=flowDir
)
p.wait()

if(p.returncode != 0):
print("[ERROR]: Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# Place and Route finished")
print("#----------------------------------------------------------------------")

time.sleep(2)

cmd = ["make", "magic_drc", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file]
p = sp.Popen(
["make", "magic_drc", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file],
cmd,
cwd=flowDir,
)
p.wait()
if(p.returncode != 0):
print("[ERROR]: Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# DRC finished")
print("#----------------------------------------------------------------------")

time.sleep(2)

cmd = ["make", "netgen_lvs", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file]
p = sp.Popen(
["make", "netgen_lvs", "PLATFORM_ARG=" + args.platform, "SPICE_FILE=" + spice_file],
cmd,
cwd=flowDir,
)
p.wait()

if(p.returncode != 0):
print("[ERROR]: Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# LVS finished")
Expand Down Expand Up @@ -274,11 +286,20 @@
print("Exiting tool....")
exit()

p = sp.Popen(["yum", "install", "-y", "libXaw-devel"])
p.wait()
p = sp.Popen(["yum", "install", "-y", "libXaw"])
cmd = ["yum", "install", "-y", "libXaw-devel"]
p = sp.Popen(cmd)
p.wait()
if p.returncode != 0:
print("Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

cmd = ["yum", "install", "-y", "libXaw"]
p = sp.Popen(cmd)
p.wait()
if p.returncode != 0:
print("Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

pdks_path = "/usr/bin/miniconda3/share/pdk/"

if args.prepex:
Expand Down
20 changes: 12 additions & 8 deletions openfasoc/generators/ldo-gen/tools/ldo-gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,13 @@
print("#----------------------------------------------------------------------")
print("# Run Synthesis and APR")
print("#----------------------------------------------------------------------")
p = sp.Popen(["make", "finish"], cwd=directories["flowDir"])
cmd = ["make", "finish"]
p = sp.Popen(cmd, cwd=directories["flowDir"])
p.wait()
if p.returncode:
print("[Error] Place and Route failed. Refer to the log file")
exit(1)
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) +\
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# Run DRC")
Expand All @@ -163,11 +165,13 @@
print("#----------------------------------------------------------------------")
print("# Run LVS")
print("#----------------------------------------------------------------------")
p = sp.Popen(["make", "netgen_lvs"], cwd=directories["flowDir"])
cmd = ["make", "netgen_lvs"]
p = sp.Popen(cmd, cwd=directories["flowDir"])
p.wait()
if p.returncode:
print("[Error] LVS failed. Refer to the report")
exit(1)
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) +\
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# LVS and DRC finished successfully")
Expand Down
50 changes: 31 additions & 19 deletions openfasoc/generators/temp-sense-gen/tools/temp-sense-gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,18 @@
# ------------------------------------------------------------------------------
# Clean the workspace
# ------------------------------------------------------------------------------
print("#----------------------------------------------------------------------")
print("# Cleaning the workspace...")
print("#----------------------------------------------------------------------")

print("#----------------------------------------------------------------------", flush=True)
print("# Cleaning the workspace...", flush=True)
print("#----------------------------------------------------------------------", flush=True)

if args.clean:
p = sp.Popen(["make", "clean_all"], cwd=genDir)
cmd = ["make", "clean_all"]
p = sp.Popen(cmd, cwd=genDir)
p.wait()
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) + "' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

p = sp.Popen(["git", "checkout", platformDir + "cdl/sky130_fd_sc_hd.spice"])
p.wait()
Expand Down Expand Up @@ -67,7 +73,7 @@
if not os.path.isdir(sky130A_path):
os.mkdir(sky130A_path)
try:
sp.Popen(
p = sp.Popen(
[
"sed -i 's/set PDKPATH \".*/set PDKPATH $env(PDK_ROOT)\/sky130A/' $PDK_ROOT/sky130A/libs.tech/magic/sky130A.magicrc"
],
Expand Down Expand Up @@ -146,37 +152,43 @@
print()
if args.mode == "verilog":
print("Exiting tool....")
exit()
sys.exit(0)

print("#----------------------------------------------------------------------")
print("# Run Synthesis and APR")
print("#----------------------------------------------------------------------")

p = sp.Popen(["make", "finish"], cwd=flowDir)
cmd = ["make", "finish"]
p = sp.Popen(cmd, cwd=flowDir)
p.wait()
if p.returncode:
print("[Error] Place and Route failed. Refer to the log file")
exit(1)
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) +\
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# Place and Route finished")
print("#----------------------------------------------------------------------")

p = sp.Popen(["make", "magic_drc"], cwd=flowDir)
cmd = ["make", "magic_drc"]
p = sp.Popen(cmd, cwd=flowDir)
p.wait()
if p.returncode:
print("[Error] DRC failed. Refer to the report")
exit(1)
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) + \
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# DRC finished")
print("#----------------------------------------------------------------------")

p = sp.Popen(["make", "netgen_lvs"], cwd=flowDir)
cmd = ["make", "netgen_lvs"]
p = sp.Popen(cmd, cwd=flowDir)
p.wait()
if p.returncode:
print("[Error] LVS failed. Refer to the report")
exit(1)
if p.returncode != 0:
print("[ERROR]: Command '" + ' '.join(cmd) + \
"' exited with non-zero return code: " + str(p.returncode))
sys.exit(p.returncode)

print("#----------------------------------------------------------------------")
print("# LVS finished")
Expand Down Expand Up @@ -262,4 +274,4 @@
sys.exit(1)

print("Exiting tool....")
exit()
sys.exit(0)
Loading