-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py #325
base: main
Are you sure you want to change the base?
Conversation
@msaligane @chetanyagoyal The test are failing I use a version |
We are handling this in a separate PR |
pdk_root = Path('/usr/bin/miniconda3/share/pdk/') | ||
pdk_root = Path('$PDK_ROOT') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has a lot of potential to fail. Please enclose all logic in a try and except block instead, where if the pdk_root can't be found, it defaults to the two possible locations (/usr/bin/...
or /home/$(logname)/...
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if it makes sense now. However it is expected that PDK_ROOT variable gets created during installation...as docker installation does it.
@chetanyagoyal please see if the new changes makes sense. However it is expected that PDK_ROOT variable gets created during installation...as docker installation does it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's see if the workflows pass
ENV PDK_ROOT=/usr/bin/miniconda3/share/pdk/
export PDK_ROOT=/home/$(logname)/miniconda3/share/pdk/