[migrate] upgrade to ESLint 9, Node.js 20 & other latest Upstream packages/actions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[update] dependencies
TechQuery
requested changes
Sep 9, 2024
package.json
Outdated
Comment on lines
78
to
81
| "*.{html,md,less,json,yml,js,ts,tsx}": [ | ||
| "eslint --fix", | ||
| "prettier --write" | ||
| ] |
There was a problem hiding this comment.
格式不对会影响 eslint 规则通过？
There was a problem hiding this comment.
格式不对会影响 eslint 规则通过？
有少数规则会，因为代码越格式规范出问题的概率越小。
There was a problem hiding this comment.
官方文档推荐写的，一个是代码质量规则，一个是格式化规则，它们的交集也用插件 disable 了，很难想象格式会影响代码质量检查
https://github.com/lint-staged/lint-staged#task-concurrency
There was a problem hiding this comment.
按照步骤，只要 eslint --fix 出问题都会再过一遍，用 prettier 收尾是正常流程？
[polish] comment message
TechQuery
requested changes
Sep 10, 2024
TechQuery
changed the title
TechQuery
requested changes
Sep 10, 2024
TechQuery
requested changes
Sep 10, 2024
TechQuery
requested changes
Sep 10, 2024
TechQuery
approved these changes
Sep 10, 2024
TechQuery
requested changes
Sep 12, 2024
[polish] import sort for some component [add] title for TSXSample [fix] form event for react
TechQuery
requested changes
Sep 13, 2024
TechQuery
requested changes
Sep 14, 2024
TechQuery
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] eslint, lint-staged
[update] dependencies