Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting run initialization. #407

Merged
merged 11 commits into from
May 7, 2024
Merged

Adapting run initialization. #407

merged 11 commits into from
May 7, 2024

Conversation

staudtMarius
Copy link
Member

Resolves #404

@staudtMarius staudtMarius added the refactoring Refactoring concerning code style, organization etc. label Apr 17, 2024
@staudtMarius staudtMarius self-assigned this Apr 17, 2024
@staudtMarius staudtMarius added the enhancement New feature or request label Apr 17, 2024
@staudtMarius staudtMarius marked this pull request as draft April 25, 2024 10:37
@staudtMarius staudtMarius marked this pull request as ready for review May 6, 2024 10:40
danielfeismann
danielfeismann requested changes May 6, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check the sonarqube issues as well, thanks! Overall just minor things, very good!

src/main/scala/edu/ie3/osmogrid/guardian/run/RunSupport.scala Outdated Show resolved Hide resolved
@staudtMarius
Copy link
Member Author

@danielfeismann Here is the issue for the power density.

danielfeismann
danielfeismann approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danielfeismann danielfeismann merged commit 83c8bf2 into dev May 7, 2024
3 checks passed
@danielfeismann danielfeismann deleted the ms/#404-adapt-run-initialization branch May 7, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@staudtMarius staudtMarius

Labels
enhancement New feature or request refactoring Refactoring concerning code style, organization etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt run initialization.
2 participants
@staudtMarius @danielfeismann