To/#158 osm model #162
Merged
To/#158 osm model #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not change |
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
============================================
+ Coverage 45.15% 45.69% +0.53%
Complexity 222 222
============================================
Files 32 34 +2
Lines 1444 1462 +18
Branches 188 188
============================================
+ Hits 652 668 +16
- Misses 763 765 +2
Partials 29 29
Continue to review full report at Codecov.
|
ckittl
suggested changes
Dec 2, 2021
| */ | ||
| def extractLandUses(ways: List[Way]): List[ClosedWay] = { | ||
| ways.collect { | ||
| case way: ClosedWay if way.containsKeyValuePair(landuse, landUseValues) => |
There was a problem hiding this comment.
As discussed orally: If the "allowed" values provided in TagUtils are not in this project anymore, the outline of the method needs adaption.
…PowerSystemUtils into to/#158-osm-model � Conflicts: � docs/OsmModel.puml
ckittl
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #158
Will most likely need some more extension later on.