Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring of ThermalGrid.handleInfeed to fix thermal storage recharge correctly when empty #931

Draft
wants to merge 16 commits into
base: dev
Choose a base branch
from

Merge branch 'refs/heads/dev' into df/#930-refactor-handleInfeed

de1b0c5
Select commit
Loading
Failed to load commit list.
Draft

Refactoring of ThermalGrid.handleInfeed to fix thermal storage recharge correctly when empty #931

Merge branch 'refs/heads/dev' into df/#930-refactor-handleInfeed
de1b0c5
Select commit
Loading
Failed to load commit list.
SonarQubeGithubPRChecks / simona Sonarqube Results succeeded Oct 1, 2024 in 11s

Quality Gate success

Passed

Analysis Details

7 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 7 Code Smells

Coverage and Duplications

  • Coverage 88.90% Coverage (83.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:simona

View in SonarQube

Annotations

Check warning on line 246 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L246 

Use the opposite operator (">=") instead.

Check warning on line 169 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L169 

This function has 8 parameters, which is greater than the 7 authorized.

Check warning on line 62 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L62 

Take the required action to fix the issue indicated by this "FIXME" comment.

Check warning on line 220 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L220 

This function has 8 parameters, which is greater than the 7 authorized.

Check warning on line 375 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L375 

Take the required action to fix the issue indicated by this "FIXME" comment.

Check warning on line 653 in src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/model/thermal/ThermalGrid.scala#L653 

Take the required action to fix the issue indicated by this "FIXME" comment.

Check warning on line 315 in src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala

See this annotation in the file changed.

@sonarqubegithubprchecks sonarqubegithubprchecks / simona Sonarqube Results

src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala#L315 

Unnecessary store before return.
View more details on SonarQubeGithubPRChecks