Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pass CODECOV_TOKEN in docker-compose.test.yml #440

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

kesara
Copy link
Member

@kesara kesara commented Jul 15, 2024

No description provided.

@kesara kesara changed the title ci: Pass CODECOV_TOKEN to docker-compose.test.yml ci: Pass CODECOV_TOKEN in docker-compose.test.yml Jul 15, 2024
@microamp
Copy link
Collaborator

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

@microamp microamp self-requested a review July 16, 2024 04:04
@microamp microamp merged commit b0678b6 into main Jul 16, 2024
2 checks passed
@kesara kesara deleted the kesara-patch-1 branch July 16, 2024 04:07
@kesara
Copy link
Member Author

kesara commented Jul 16, 2024

Alternatively, we can modify .github/workflows/tests.yml to include PRs along with the main branch.

The GHA is already configured to run on tests with pull_request trigger and this change makes sure CODECOV_TOKEN gets passed to the docker instance that runs tests and uploads coverage to codecov.

@microamp
Copy link
Collaborator

Update: After merging this PR, I rebased the main branch into the test/serializers branch here, #439.

However, I can see that that hasn't fixed the issue. https://github.com/ietf-tools/bibxml-service/actions/runs/9950576461/job/27488655210?pr=439#step:7:302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants