feat: add pylint #188
Closed
feat: add pylint #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
commented
Sep 5, 2024
|
|
||
| # Add files or directories to the blacklist. They should be base names, not | ||
| # paths. | ||
| ignore=CVS,migrations |
There was a problem hiding this comment.
CVS is vestigial
I'm surprised we're ignoring migrations.
There was a problem hiding this comment.
new pylint --generate-rcfile generates this same set
rjsparks
commented
Sep 5, 2024
| # paths. | ||
| ignore=CVS,migrations | ||
|
|
||
| # Add files or directories matching the regex patterns to the blacklist. The |
rjsparks
commented
Sep 5, 2024
| # A comma-separated list of package or module names from where C extensions may | ||
| # be loaded. Extensions are loading into the active Python interpreter and may | ||
| # run arbitrary code | ||
| extension-pkg-whitelist= |
There was a problem hiding this comment.
whitelist
We may not control this name, but I wonder if it's still a valid configuration name?
There was a problem hiding this comment.
from a newly generated rc:
# A comma-separated list of package or module names from where C extensions may
# be loaded. Extensions are loading into the active Python interpreter and may
# run arbitrary code. (This is an alternative name to extension-pkg-allow-list
# for backward compatibility.)
extension-pkg-whitelist=
rjsparks
commented
Sep 5, 2024
| # Pylint and this flag can prevent that. It has one side effect, the resulting | ||
| # AST will be different than the one from reality. This option is deprecated | ||
| # and it will be removed in Pylint 2.0. | ||
| optimize-ast=no |
There was a problem hiding this comment.
probably long gone - we are at pylint 3
There was a problem hiding this comment.
confirmed - no longer relevant
rjsparks
commented
Sep 5, 2024
|
|
||
| # Exceptions that will emit a warning when being caught. Defaults to | ||
| # "Exception" | ||
| overgeneral-exceptions=builtins.Exception |
rjsparks
commented
Sep 5, 2024
| @@ -0,0 +1,408 @@ | |||
| [MASTER] | |||
There was a problem hiding this comment.
MASTER (new pylint generates MAIN)
jennifer-richards
requested changes
Sep 9, 2024
There was a problem hiding this comment.
I think we should take the lessons from here and go with #189 instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #187, and should be evaluated after that is merged.
It brings in a copy of the datatracker's .pylintrc, which we should review carefully.