refactor: improve DocumentTable types #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to draft - no need to look at this now, I am not sure it was doing what I thought it was doing. Will come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to clean up some type complaints in the DocumentTable. It clears up all the complaints I see in DocumentTable.vue itself. Unfortunately the actual places the component is used are either seeing an
anytype or are confused because theidfield is shown as possibly undefined due to limitations in the Django API generation. I'm hoping to clear those up eventually.Also fixes a minor bug in the
labelscolumn where the ID was being displayed beside each label.Best to look at the diffs with whitespace changes suppressed because some reformatting got mixed in - sorry about that.