Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Deduplicate index entries #1050

Merged
merged 3 commits into from
Oct 27, 2023
Merged

fix: Deduplicate index entries #1050

merged 3 commits into from
Oct 27, 2023

Conversation

jennifer-richards
Copy link
Member

@jennifer-richards jennifer-richards commented Oct 26, 2023 •
edited by kesara
Loading

This PR addresses two issues:

  • Duplicate entries per term in the index.
  • Duplicate terms in the index.

Fixes #988

@jennifer-richards jennifer-richards mentioned this pull request Oct 26, 2023
Closed
1 task
@kesara kesara changed the title feat: Deduplicate index entries fix: Deduplicate index entries Oct 26, 2023
@kesara
Copy link
Member

kesara commented Oct 26, 2023

The root cause for having duplicate terms is some terms are stored with white spaces due to line breaks.
For example, there can be two unique entries because one term is 'Oblivious Gateway Resource' and the other is 'Oblivious Gateway Resource' (due to line breaks).

@kesara kesara requested a review from rjsparks October 26, 2023 21:14
@kesara kesara merged commit a5d46ad into ietf-tools:main Oct 27, 2023
13 checks passed
@jennifer-richards jennifer-richards deleted the dedup-index branch October 27, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesara kesara kesara approved these changes

@rjsparks rjsparks rjsparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deduplicate index entries
3 participants
@jennifer-richards @kesara @rjsparks