Delete only expired segments which are closed (#905)

iggy-rs · Apr 16, 2024 · 59999f1 · 59999f1
1 parent ae5c9c8
commit 59999f1
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/server/Cargo.toml b/server/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "server"
-version = "0.2.20"
+version = "0.2.21"
 edition = "2021"
 build = "src/build.rs"
 

diff --git a/server/src/streaming/partitions/segments.rs b/server/src/streaming/partitions/segments.rs
@@ -26,7 +26,7 @@ impl Partition {
     pub async fn get_expired_segments_start_offsets(&self, now: u64) -> Vec<u64> {
         let mut expired_segments = Vec::new();
         for segment in &self.segments {
-            if segment.is_expired(now).await {
+            if segment.is_closed && segment.is_expired(now).await {
                 expired_segments.push(segment.start_offset);
             }
         }

diff --git a/server/src/streaming/segments/segment.rs b/server/src/streaming/segments/segment.rs
@@ -122,7 +122,7 @@ impl Segment {
             return false;
         }
 
-        let last_messages = self.get_messages(self.end_offset, 1).await;
+        let last_messages = self.get_messages(self.current_offset, 1).await;
         if last_messages.is_err() {
             return false;
         }