OF-2784 & OF-2785: Various IPv6-related changes #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion#isAddressInRange The check used to see if a particular IP address is in a set of addresses or addres ranges should also be able to operate on IPv6 addresses (not just IPv4).
A new utility class in which IP-related helper methods are centralized. Includes unit tests.
This uses the newly introduced IP utility class (from the previous commit) to phase out duplicated functionality in other classes.
Now checks for the presence of A (IPv4) and AAAA (IPv6) records, allowing users to assert if their DNS configuration is correct. The index page (which pops up a warning to look at the analytics-page if needed) now operates based on a timeout. This prevents slow DNS resolution from keeping the index-page to load in a timely manner. This functionality depends on the new feature introduced by OF-2885.
This reworks the login restrictions that can be configured on the Registration & Login page. The text area that was used to fill out _all_ IP addresses / ranges is now replaced with a table and form that takes individual IP addresses and ranges. Support for IPv6 addresses (and ranges) has been added. All pre-existing notation forms remain functional. The wildcard-based annotation form to denote an IPv4-range (eg `198.41.100.*`) now gets translated in a CIDR variant (`198.51.100.0/24`) when saved. The wildcard notation is _not_ supported for IPv6.
This reworks the restrictions that can be configured on the Admin Console Access page. The text area that was used to fill out _all_ IP addresses / ranges is now replaced with a table and form that takes individual IP addresses and ranges. Support for IPv6 addresses (and ranges) has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of related commits (please look at the individual commit messages) that intent to update support for IPv6 in Openfire.
The majority of the changes can be summed up as: