Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failed URLs in new downloads #121

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

deldesir
Copy link
Collaborator

@deldesir deldesir commented Feb 7, 2024

🚀 Pull Request Overview:

With this PR, failed URLs will not carry on new downloads. No need to delete the database prior testing anymore (we used to do this to have a clean testing environment).

Only the URL submitted (or the ones in case of a Playlist) will be processed.

📋 Checklist:

  • Tested the changes thoroughly.

🐛 Related issue(s): #114, #120

📌 Testing scenarios:

  • Submit a membership-only or a live URL
  • Observe the NoneType Error
  • Submit a valid URL
  • Observe the successful download without an additional attempt to download the previous failed URL

cc @EMG70

@EMG70
Copy link

EMG70 commented Feb 7, 2024

iiab-diagnostics http://sprunge.us/KhB92E?en

  • Submit a membership-only or a live URL https://www.youtube.com/watch?v=JufLGbcXXjY  ✅  
    
  • Observe the NoneType Error ✅  
    

output now says (failed,no such column)
Screenshot from 2024-02-07 22-29-02

  • Submit a valid URL https://www.youtube.com/watch?v=HbgzrKJvDRw ✅  
    

Valid url resulted in (no such column :error ,status finished)

  • Observe the successful download without an additional attempt to download the previous failed URL ❌
    
  • Screenshot from 2024-02-07 22-38-12

@deldesir
Copy link
Collaborator Author

deldesir commented Feb 8, 2024

Thanks @EMG70 for testing and reporting. Fixed in #122

@holta holta added the bug Something isn't working label Feb 8, 2024
@deldesir deldesir deleted the deldesir-patch-7 branch July 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants